Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement simple caching #9

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Implement simple caching #9

merged 4 commits into from
Jul 15, 2024

Conversation

xukai92
Copy link
Collaborator

@xukai92 xukai92 commented Jul 15, 2024 •
edited
Loading

  • 7982876 implements row-level caching by assuming a partial/cache dataset is provided by its file path
  • a150183 run tox on the existing code base to make the linter happy

tested via using

gen_data = sdg.generate(ds, "~/tmp/cache.jsonl")

in L58 of scripts/test_freeform_skills.py

@xukai92
feat: support caching
7982876 
Signed-off-by: Kai Xu <xuk@ibm.com>
@xukai92
format(tox)
a150183 
Signed-off-by: Kai Xu <xuk@ibm.com>
@xukai92
fix: make sure path is handled properly
8f7b8d4 
Signed-off-by: Kai Xu <xuk@ibm.com>
@xukai92
format: apply linter suggestions
d350f0e 
Signed-off-by: Kai Xu <xuk@ibm.com>
@aakankshaduggal aakankshaduggal merged commit 09decca into main Jul 15, 2024
7 of 9 checks passed
This was referenced Jul 18, 2024
Closed
Closed
@shivchander shivchander mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakankshaduggal aakankshaduggal aakankshaduggal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xukai92 @aakankshaduggal