Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects cannot be added in this modification BluePrint3D. #56

Open
AfanasievAM opened this issue Jul 21, 2020 · 9 comments
Open

Objects cannot be added in this modification BluePrint3D. #56

AfanasievAM opened this issue Jul 21, 2020 · 9 comments

Comments

@AfanasievAM
Copy link

Can't added objects on 3D-plane in Demo version and Locale version.

  1. Go to '3D'
  2. Click on '+'
  3. Insert any object 'click'
  4. See nothing on 3D-plane.

Desktop:

  • OS: Catalina 10.15.5
  • Chrome, 84.0.4147.89

There is also a bug on the local version.

@technbuzz
Copy link

Normally you would click on the floor in 3D plane and then add item to properly place in that room. But I am also facing this problem with these new changes.

@AfanasievAM
Copy link
Author

In any case, I can't add any objects. Even if you choose floor on 3D plan.

@dawilster
Copy link

I'm seeing the same issue using the demo in Chrome and Safari as well

@dawilster
Copy link

dawilster commented Aug 6, 2020

I thought I'd jump into the codebase and see what I could find. It seems this line is raising an exception whenever you try to add an item.

item.js:80

        let mixer = new AnimationMixer(this._loadedgltfobject.scene); <----
        let clips = loaded_gltf_entity.animations;
        if (clips != undefined) {
            if (clips.length) {
                // clips.forEach((clip) => {
                //     console.log(clip);
                //     console.log(clip.name, clip.duration);
                //     // mixer.clipAction(clip).play();
                // });
                let frame = this.metadata.frame;
                let clip = AnimationClip.findByName(clips, frame);
                if (clip != undefined && clip != null) {
                    mixer.clipAction(clip).play();
                    mixer.update(0.0);
                }

            }
        }
        this.add(this._loadedgltfobject.scene);

I can't quite seem to see where this._loadedgltfobject is defined.

Also, forgive my ignorance. I know nothing about three.js or your repo but I stumbled upon it today and was so impressed I couldn't help but dive in.

@aalavandhaann
Copy link
Owner

Hello dawlister,

My sincere apologies for the delayed reply. Actually I am in the process of overhauling the entire framework. This is to move it closer to a much cleaner codebase. You can see the latest version now on the master. I am slowly trying to add back all the missing functionalities and it's almost there. The next step is to facilitate the adding of items. But given that the threejs has moved to Gltf instead of legacy formats I am rather finding it difficult to find free models for the demo purposes. Stay tuned and thanks for your kind words

@technbuzz
Copy link

It's good to see those changes, when they are expected to be complete. I am using version 1 and wanted to cherry pick from the version 2?

I have some question for my own understanding, I see you used the pixijs, what the benefit we got from that? and you switched to parcel for bundling?

@aalavandhaann
Copy link
Owner

parcel

  • It wins in easy setup
  • It wins with lesser configuration scripts and files
  • But it terribly loses to filesize, which is okay to overlook atm

pixijs

  • A good wrapper of WebGL for 2D graphics
  • This reduces and opens for a cleaner codebase for viewer2d or floorplaner as it is called ATM
  • Also, many things that I found as a cumbersome process to implement is easier (panning, zooming, matrix operations etc)

I am using version 1 and wanted to cherry pick from the version 2?

I am afraid it is not going to be a easy ride for this one. The major reason I overhauled the entire framework is to lose some of the implementation mechanisms that I disagree about. However, goodluck on that.

Regards,
#0K

@technbuzz
Copy link

Thank you very much for answering my question with explanation. Albeit, I do have some other question, if you'd like to answer

  • Why the texture on 3d viewer looks kind a dark?
  • The angles that appear when walls are conjoined are no more, are you gonna bring them back?
  • What do you think when the new change wills be stabilized?
  • PIXIjs also use webgl, is it strong enough to replace the threejs?

@ravitejachillara
Copy link

Hello dawlister,

My sincere apologies for the delayed reply. Actually I am in the process of overhauling the entire framework. This is to move it closer to a much cleaner codebase. You can see the latest version now on the master. I am slowly trying to add back all the missing functionalities and it's almost there. The next step is to facilitate the adding of items. But given that the threejs has moved to Gltf instead of legacy formats I am rather finding it difficult to find free models for the demo purposes. Stay tuned and thanks for your kind words

I can help you out for 3D models in any format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants