Rails 4 Support and Travis Integration #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ails version is 4 or greater. Update specs to eliminate deprecations, use more modern FactoryGirl syntax. Change default rake task to use built-in RSpec task.
|
Looks great Peter! I'm in SF as well; I owe you a beer. :) |
aantix
added a commit
that referenced
this pull request
Jul 23, 2013
Rails 4 Support and Travis Integration
This was referenced Jul 23, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
i) Make attr_accessible inclusion conditional on ActiveRecord version, and doesn't include those in the models for Rails 4 and higher
ii) Updates the specs to eliminate deprecations
iii) Changes the specs to use modern FactoryGirl syntax
iv) Changed the default Rake task to use the built-in RSpec task
v) Added a .travis.yml that tests against MRI Rubies and Rails versions