Feature request: adjustable color and width

[nitefood]

First of all: this is amazing!

It would be nice to be able to use a different color for graphing, and to specify a maximum width for the graph.

Thanks for this gem!

[aantn]

That should be easy to do. I'll get around to it eventually, but feel free to give it a go yourself and open a PR.

…

On Mon, Nov 30, 2020, 15:55 Adriano Provvisiero ***@***.***> wrote: First of all: this is amazing! It would be nice to be able to use a different color for graphing, and to specify a maximum width for the graph. Thanks for this gem! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADYUB5DWLRR3L2CIW26WG3SSOP5FANCNFSM4UHTMHZQ> .

[aantn]

Any interest in adding the color feature? I can point you at the exact lines of code to modify.

[nitefood]

I'm sorry, I have really zero experience with Rust, otherwise I would've been glad to contribute

[aantn]

No worries. What command line flags would you like to see for the color? How would you like to specify it?

[nitefood]

well I think the standard [-c|--color] would be spot on. And regarding how to specify it, I guess the standard xterm 256 color codes would be more than plenty for everybody. If you want to go the extra mile, support to specify them by their Xterm name (ie black, green, etc) would be awesome!

[aantn]

Any thoughts on how this should interact with the ability to run multiple commands?

…

On Sat, Dec 5, 2020, 17:35 Adriano Provvisiero ***@***.***> wrote: well I think the standard [-c|--color] would be spot on. And regarding how to specify it, I guess the standard xterm 256 color codes <https://jonasjacek.github.io/colors/> would be more than plenty for everybody. If you want to go the extra mile, support to specify them by their Xterm name (ie black, green, etc) would be awesome! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADYUB2OVQXJ2CGYSAPADV3STJHNJANCNFSM4UHTMHZQ> .

[nitefood]

Perhaps specifying --color multiple times, or maybe specifying multiple color codes (comma/space separated) with a single --color option. I'm not sure how rust handles cmdline options, but I guess it shouldn't be mandatory to specify a color for every command output. That way, if I specify one color and run two commands, only the first one would be colored, while the second one should be left at the default. --color black white or --color black,white make for simpler and more intuitive usage, than, say, --color1 black --color2 white etc. IMHO.

[nitefood]

also nice to have: a --default-color switch that could be used if I just want to change the main theme color regardless of the number of commands passed