Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAIL test on armh: libuv time not positive #102

Closed
RiderALT opened this issue Mar 12, 2021 · 4 comments
Closed

FAIL test on armh: libuv time not positive #102

RiderALT opened this issue Mar 12, 2021 · 4 comments

Comments

@RiderALT
Copy link

ASSERT libuv time not positive
FAIL libuv time not positive

luv 0.5.7 with internal libuv and external libuv - the same result.

ALT Linux Sisyphus, armh 32bit.
aantron added a commit that referenced this issue Mar 12, 2021
@aantron
Tests: relax assertion in Luv.Loop.now test
03627cd 
See #102.
@aantron
Copy link
Owner

aantron commented Mar 12, 2021

Can you try with the linked commit, 03627cd?

@RiderALT
Copy link
Author

03627cd did not help.

ASSERT libuv time negative
FAIL libuv time negative

I'll see what is happening there in detail later.
Thanks.

aantron added a commit that referenced this issue Mar 12, 2021
@aantron
Time test: compare at uint64_t, not int
42c2c7b 
See #102.
@aantron
Copy link
Owner

aantron commented Mar 12, 2021

Can you try with 42c2c7b? It is likely due to the uint64_t being taken modulo 2^31 before the comparison in the test case, during the conversion to OCaml int.

@RiderALT
Copy link
Author

Anton, thanks. With the 42c2c7b test passed.

@aantron aantron mentioned this issue May 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aantron @RiderALT