-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider requiring that the client_uri
is a prefix of the client_id
#10
Comments
This would complicate something like a development client_id metadata document provider, which would hinder developer experience getting started with using client_id metadata documents. See also #12 |
Regarding #12, if we did have a "metadata as a service", think it would be reasonable to enforce that the |
@matthieusieben I think it could only be a "SHOULD" and not a "MUST" at best. So:
Unless the "client metadata document as a service" server has some way of generating a page for |
There's also language in the dynamic client registration RFC about
As client metadata document support is effectively open client registration, perhaps we need a reminder of this under the security considerations? |
Since the user comes from the client origin (can be checked through the In our implementation, we do enforce a same prefix policy for that reason. In the case of "loopback clients" (clients that do not host their own metadata document, we might need to come up with a name for those), we do not allow, or show, any uri, logo or name (besides I strongly believe that:
For all these reasons, I think that a same prefix policy, and an indentifiable "loopback client" uri scheme should really be specced. |
The
client_uri
value is meant to point to a web page about the client. Theclient_id
is the JSON metadata. So it would be reasonable for someone to implement this with values such as:Requiring that the
client_uri
is a prefix means we can recommend displaying that whole value to the user, rather than only the hostname (more risky in shared domain situations) or the fullclient_id
(more noisy with the potential for long strings that might scare the user)The text was updated successfully, but these errors were encountered: