Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add A2R flux format support #809

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Add A2R flux format support #809

merged 1 commit into from
Jul 9, 2023

Conversation

FakeShemp
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New filesystem, test images in [url]
  • New media image, test images in [url]
  • New partition scheme, test images in [url]
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

From doc: https://applesaucefdc.com/a2r

Implements reading version 2 and 3. Writing only version 3.

@FakeShemp FakeShemp force-pushed the fakeshemp/a2r branch 2 times, most recently from 0b986c6 to bf5db1d Compare July 8, 2023 20:10
claunia
claunia requested changes Jul 9, 2023
View reviewed changes
Copy link
Collaborator

@claunia claunia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember we do not throw exceptions, we return error codes.

Aaru.Images/A2R/Read.cs Outdated Show resolved Hide resolved
Aaru.Images/A2R/Read.cs Outdated Show resolved Hide resolved
Aaru.Images/SuperCardPro/Read.cs Outdated Show resolved Hide resolved
@claunia claunia merged commit 1eb45e5 into devel Jul 9, 2023
@FakeShemp FakeShemp deleted the fakeshemp/a2r branch July 9, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claunia claunia claunia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FakeShemp @claunia