Fix is_xs_date* in Python to match first (#307)

We make the verification functions ``is_xs_date*`` to match against the
patterns first to avoid bugs related to unexpected date/time formats.

Author: mristin

test_data/python/test_main/aas_core_meta.v3rc2/expected_output/verification.py

@@ -1274,15 +1274,14 @@ def _is_leap_year(year: int) -> bool:
 
 
 def is_xs_date(value: str) -> bool:
-    """
-    Check that :paramref:`value` is a valid ``xs:date``.
-
-    We can not use :py:func:`datetime.date.strptime` as it does not
-    handle years below 1000 correctly on Windows (*e.g.*, ``-999-01-01``).
-    """
-    if matches_xs_date(value) is False:
+    """Check that :paramref:`value` is a valid ``xs:date``."""
+    if not matches_xs_date(value):
         return False
 
+    # NOTE (mristin, 2022-11-23):
+    # We can not use :py:func:`datetime.datetime.strptime` as it does not
+    # handle years below 1000 correctly on Windows (*e.g.*, ``-999-01-01``).
+
     # NOTE (mristin, 2022-10-30):
     # We need to match the prefix as zone offsets are allowed in the dates. Optimally,
     # we would re-use the pattern matching from :py:func`matches_xs_date`, but this
@@ -1312,39 +1311,34 @@ def is_xs_date(value: str) -> bool:
     else:
         max_days = _DAYS_IN_MONTH[month]
 
-    # We accept the zero year for astronomical settings,
-    # see: https://en.wikipedia.org/wiki/Year_zero
-
     if day > max_days:
         return False
 
     return True
 
 
 def is_xs_date_time(value: str) -> bool:
-    """
-    Check that :paramref:`value` is a valid ``xs:dateTime``.
+    """Check that :paramref:`value` is a valid ``xs:dateTime``."""
+    # NOTE (mristin, 2022-11-23):
+    # We can not use :py:func:`datetime.datetime.strptime` as it does not
+    # handle years below 1000 correctly on Windows (*e.g.*, ``-999-01-01``).
 
-    We can not use :py:func:`datetime.datetime.strptime` as it does not
-    handle years below 1000 correctly on Windows (*e.g.*, ``-999-01-01``).
-    """
-    if matches_xs_date_time(value) is False:
+    if not matches_xs_date_time(value):
         return False
 
     date, _ = value.split('T')
     return is_xs_date(date)
 
 
 def is_xs_date_time_stamp(value: str) -> bool:
-    """
-    Check that :paramref:`value` is a valid ``xs:dateTimeStamp``.
-
-    We can not use :py:func:`datetime.datetime.strptime` as it does not
-    handle years below 1000 correctly on Windows (*e.g.*, ``-999-01-01``).
-    """
-    if matches_xs_date_time_stamp(value) is False:
+    """Check that :paramref:`value` is a valid ``xs:dateTimeStamp``."""
+    if not matches_xs_date_time_stamp(value):
         return False
 
+    # NOTE (mristin, 2022-11-23):
+    # We can not use :py:func:`datetime.datetime.strptime` as it does not
+    # handle years below 1000 correctly on Windows (*e.g.*, ``-999-01-01``).
+
     date, _ = value.split('T')
     return is_xs_date(date)
 

test_data/python/test_main/aas_core_meta.v3rc2/input/snippets/Verification/value_consistent_with_xsd_type.py

@@ -59,15 +59,14 @@ def _is_leap_year(year: int) -> bool:
 
 
 def is_xs_date(value: str) -> bool:
-    """
-    Check that :paramref:`value` is a valid ``xs:date``.
-
-    We can not use :py:func:`datetime.date.strptime` as it does not
-    handle years below 1000 correctly on Windows (*e.g.*, ``-999-01-01``).
-    """
-    if matches_xs_date(value) is False:
+    """Check that :paramref:`value` is a valid ``xs:date``."""
+    if not matches_xs_date(value):
         return False
 
+    # NOTE (mristin, 2022-11-23):
+    # We can not use :py:func:`datetime.datetime.strptime` as it does not
+    # handle years below 1000 correctly on Windows (*e.g.*, ``-999-01-01``).
+
     # NOTE (mristin, 2022-10-30):
     # We need to match the prefix as zone offsets are allowed in the dates. Optimally,
     # we would re-use the pattern matching from :py:func`matches_xs_date`, but this
@@ -97,39 +96,34 @@ def is_xs_date(value: str) -> bool:
     else:
         max_days = _DAYS_IN_MONTH[month]
 
-    # We accept the zero year for astronomical settings,
-    # see: https://en.wikipedia.org/wiki/Year_zero
-
     if day > max_days:
         return False
 
     return True
 
 
 def is_xs_date_time(value: str) -> bool:
-    """
-    Check that :paramref:`value` is a valid ``xs:dateTime``.
+    """Check that :paramref:`value` is a valid ``xs:dateTime``."""
+    # NOTE (mristin, 2022-11-23):
+    # We can not use :py:func:`datetime.datetime.strptime` as it does not
+    # handle years below 1000 correctly on Windows (*e.g.*, ``-999-01-01``).
 
-    We can not use :py:func:`datetime.datetime.strptime` as it does not
-    handle years below 1000 correctly on Windows (*e.g.*, ``-999-01-01``).
-    """
-    if matches_xs_date_time(value) is False:
+    if not matches_xs_date_time(value):
         return False
 
     date, _ = value.split('T')
     return is_xs_date(date)
 
 
 def is_xs_date_time_stamp(value: str) -> bool:
-    """
-    Check that :paramref:`value` is a valid ``xs:dateTimeStamp``.
-
-    We can not use :py:func:`datetime.datetime.strptime` as it does not
-    handle years below 1000 correctly on Windows (*e.g.*, ``-999-01-01``).
-    """
-    if matches_xs_date_time_stamp(value) is False:
+    """Check that :paramref:`value` is a valid ``xs:dateTimeStamp``."""
+    if not matches_xs_date_time_stamp(value):
         return False
 
+    # NOTE (mristin, 2022-11-23):
+    # We can not use :py:func:`datetime.datetime.strptime` as it does not
+    # handle years below 1000 correctly on Windows (*e.g.*, ``-999-01-01``).
+
     date, _ = value.split('T')
     return is_xs_date(date)