Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a common nav and footer for all pages #82

Merged
merged 7 commits into from Apr 15, 2019
Merged

Added a common nav and footer for all pages #82

merged 7 commits into from Apr 15, 2019

Conversation

mark-nakachon
Copy link

@mark-nakachon mark-nakachon commented Apr 12, 2019 •
edited by aashutoshrathi

Checklist:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you successfully ran tests with your changes locally?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

Issues Solved

Fixes #80

aashutoshrathi
aashutoshrathi requested changes Apr 13, 2019
View reviewed changes
Copy link
Owner

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post a screenshot?

@mark-nakachon
Copy link
Author

Screenshot from 2019-04-13 20-41-07

aashutoshrathi
aashutoshrathi requested changes Apr 13, 2019
View reviewed changes
Copy link
Owner

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Change partial to components.
  • Give an empty newline at the end of every file.

Rest LGTM as of now. ✨

aashutoshrathi
aashutoshrathi approved these changes Apr 15, 2019
View reviewed changes
Copy link
Owner

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@aashutoshrathi aashutoshrathi merged commit b72e6b1 into aashutoshrathi:dev Apr 15, 2019
aashutoshrathi added a commit that referenced this pull request Nov 19, 2019
@aashutoshrathi
Dev to Master (#81)
c523846 
* HackerEarth Added (#63)

* hackerearth added

* hackerearth

* checker.py edited

* input folder deleted

* folders merged

* Add new demo file in dev branch (#64)

* Add new demo file

* HackerEarth Added (#63)

* hackerearth added

* hackerearth

* checker.py edited

* input folder deleted

* folders merged

* Testcase generator for CodeChef #53 (#66)

* Add new demo file (#58)

* TestCase generator for CodeChef

* ChangedFileNameFormat

* Server Initialization (#68)

* Add Server Deployment

* Move package.json to root

* Throw error when unable to execute (#69)

* hackerearth added

* hackerearth

* checker.py edited

* input folder deleted

* Add new demo file (#58)

* folders merged

* blank output exception

* New line

* new line

* 🔥 Remove extraspace

* ➕ Add Weekly Digest Bot

* added a route for file upload

* modified changes

* added timestamp to resolve conflicts

* updated server/index.js

* update UI

* added a route for solution upload (#73)

* added a route for file upload

* modified changes

* added timestamp to resolve conflicts

* updated server/index.js

* added changes

* deleted uploads folder

* made changes to UI

* updated the action attribute

* UI update (#76)

* added a route for file upload

* modified changes

* added timestamp to resolve conflicts

* updated server/index.js

* update UI

* made changes to UI

* updated the action attribute

* 🙈 Updated gitignore

* Database config (#78)

* added cors and headers (#79)

* Added a common nav and footer for all pages (#82)

* added cors and headers

* added header and footer

* CHANGED PARTIALS TO COMPONENTS

* ☸️ Add newlines at the end of templates

* Adding suggested changes - pr from dev to dev (#84)

* Adding suggested changes

* Adding suggested changes

* Added endpoints to all links on homepage (#85)

* added cors and headers

* added header and footer

* CHANGED PARTIALS TO COMPONENTS

* added links to all endpoints on homepage

* Added a new line at the end of Landin.ejs

* Initialized docker environment (#88)

* squashed my commits

* Initialized Docker Environment

* Added new line to Docker file

* Added new line

* Updated package.json

* Updated Dockerfile

* Updated README.md

* Updated README.md

* Made a quick change

* Removed question mark

* implemented registration and login for the user (#94)

* added registration

* completed registration

* completed login

* added form validation

* added necessary changes

* fixed title

* fixed issues

* executing scripts as soon as user uploaded file (#95)

* executing scripts as soon as user uploaded

* fixed issue

* Added Protection to all the routes (#101)

* squashed my commits

* added protection to all routes

* Added Logout Route (#100)

* executing scripts as soon as user uploaded

* fixed issue

* user can now download zipped files on server

* added logout route

* fixed get to post

* Added logic  and and view to display user files (#102)

* squashed commits

* added logic and view to display user uploaded files

* made changes

* Fixed redundant imports

* Added a new line at the end

* Add Husky and Travis (#105)

* set automatic-code-fixing using eslint prettier husky lint-staged editorconfig

* Added new line to .editorconfig

* Added new line t

* Done with this

* Added new line

* Added new line

* added travis

* fixed with eslint

* fixed error in travis

* fixed errors using eslint

* Fixed bug in /register route (#111)

* squashed my commits

* fixed bug in /register route

* Added options view

* Added a new line for form.ejs

* Update lint-staged requirement from ^8.1.7 to ^9.0.2 (#129)

Updates the requirements on [lint-staged](https://github.com/okonet/lint-staged) to permit the latest version.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](lint-staged/lint-staged@v8.1.7...v9.0.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Update husky requirement from ^2.3.0 to ^3.0.0 (#127)

Updates the requirements on [husky](https://github.com/typicode/husky) to permit the latest version.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](typicode/husky@v2.3.0...v3.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Update express-validator requirement from ^5.3.1 to ^6.1.1 (#126)

Updates the requirements on [express-validator](https://github.com/express-validator/express-validator) to permit the latest version.
- [Release notes](https://github.com/express-validator/express-validator/releases)
- [Commits](express-validator/express-validator@v5.3.1...v6.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Update prettier-eslint-cli requirement from ^4.7.1 to ^5.0.0 (#124)

Updates the requirements on [prettier-eslint-cli](https://github.com/prettier/prettier-eslint-cli) to permit the latest version.
- [Release notes](https://github.com/prettier/prettier-eslint-cli/releases)
- [Changelog](https://github.com/prettier/prettier-eslint-cli/blob/master/CHANGELOG.md)
- [Commits](prettier/prettier-eslint-cli@v4.7.1...v5.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Update eslint requirement from ^5.16.0 to ^6.0.1 (#123)

Updates the requirements on [eslint](https://github.com/eslint/eslint) to permit the latest version.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v5.16.0...v6.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Updates

* Update eslint-plugin-node requirement from ^9.0.1 to ^10.0.0 (#135)

Updates the requirements on [eslint-plugin-node](https://github.com/mysticatea/eslint-plugin-node) to permit the latest version.
- [Release notes](https://github.com/mysticatea/eslint-plugin-node/releases)
- [Commits](mysticatea/eslint-plugin-node@v9.0.1...v10.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump prettier-eslint from 8.8.2 to 9.0.1 (#140)

Bumps [prettier-eslint](https://github.com/prettier/prettier-eslint) from 8.8.2 to 9.0.1.
- [Release notes](https://github.com/prettier/prettier-eslint/releases)
- [Changelog](https://github.com/prettier/prettier-eslint/blob/master/CHANGELOG.md)
- [Commits](prettier/prettier-eslint@v8.8.2...v9.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashutoshrathi aashutoshrathi aashutoshrathi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set a common Nav and Footer for all web pages
3 participants
@mark-nakachon @aashutoshrathi @harishchennupati