Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend timestamps with namespace to avoid naming conflicts #754

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/aasm/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,9 @@ def setup_timestamps(aasm_name)

after_all_transitions do
if self.class.aasm(:"#{aasm_name}").state_machine.config.timestamps
ts_setter = "#{aasm(aasm_name).to_state}_at="
namespace = self.class.aasm(:"#{aasm_name}").state_machine.config.namespace
base_setter = "#{aasm(aasm_name).to_state}_at="
ts_setter = !!namespace ? "#{namespace}_#{base_setter}" : base_setter
respond_to?(ts_setter) && send(ts_setter, ::Time.now)
end
end
Expand Down
13 changes: 13 additions & 0 deletions spec/models/timestamps_with_namespace_machine_example.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
class TimestampsWithNamespaceMachineExample
include AASM

attr_accessor :new_opened_at

aasm :my_state, timestamps: true, namespace: :new do
state :opened

event :open do
transitions to: :opened
end
end
end
5 changes: 5 additions & 0 deletions spec/unit/timestamps_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,9 @@
object = TimestampsWithNamedMachineExample.new
expect { object.open }.to change { object.opened_at }.from(nil).to(instance_of(::Time))
end

it 'calls a timestamp setter based on the state name and namespace when entering a new state using a namespace state machine' do
object = TimestampsWithNamespaceMachineExample.new
expect { object.open }.to change { object.new_opened_at }.from(nil).to(instance_of(::Time))
end
end