irc-proto: allow modes with no prefix #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinetd
force-pushed
the
query_mode
branch
2 times, most recently
from
f24d8d9
to
ac97586
Compare
irc clients can query the details of some modes (e.g. request list of banned users) by sending a message with no plus or minus prefix, e.g. "MODE #chan b"
aatxe
approved these changes
Jun 24, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
irc clients can query the details of some modes (e.g. request list of banned users) by sending a message with no plus or minus prefix, e.g. "MODE #chan b"
Not sure why this hadn't bitten me earlier, but now apparently the Framed tokio codec stream I'm reading stops processing data on first error so even if I could just ignore this it effectively disconnects my client, making channels rather painful.
Happy to rename NoPrefix to something else, from what I could see it's a query so Query? But Plus and Minus are rather litteral and not Add / Remove so NoPrefix is probably just as good.
Thanks!