Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo #717

Merged
merged 5 commits into from
Nov 3, 2022
Merged

fix: typo #717

merged 5 commits into from
Nov 3, 2022

Conversation

Bojidar00
Copy link
Contributor

Closes: #700

@miguelmtzinf
Copy link
Contributor

Thanks for the fix @Bojidar00 !

@The-3D
Copy link
Contributor

The-3D commented Oct 24, 2022

can we point this to the 3.0.1 branch?

@Bojidar00 Bojidar00 changed the base branch from master to feat/3.0.1 October 26, 2022 09:36
kyzia551
kyzia551 reviewed Nov 1, 2022
View reviewed changes
contracts/protocol/pool/DefaultReserveInterestRateStrategy.sol
function calculateInterestRates(DataTypes.CalculateInterestRatesParams calldata params)
external
function calculateInterestRates(DataTypes.CalculateInterestRatesParams memory params)
public
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miguelmtzinf is it needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are already part of the code (github is not calculating the diff correctly). They have been introduced per BGD's request (for the V2-V3 migration).
Here PRs: #721 and #712

@miguelmtzinf miguelmtzinf changed the base branch from feat/3.0.1 to feat/3.0.1-typos November 2, 2022 18:26
@miguelmtzinf miguelmtzinf merged commit 9666e99 into aave:feat/3.0.1-typos Nov 3, 2022
@github-actions github-actions bot mentioned this pull request Dec 28, 2022
Merged
This was referenced Jun 14, 2024
Closed
Closed
Closed
@tobistudio tobistudio mentioned this pull request Jul 13, 2024
Closed
@tobistudio tobistudio mentioned this pull request Jul 23, 2024
Closed
This was referenced Jul 31, 2024
Closed
Closed
Closed
@tobistudio tobistudio mentioned this pull request Aug 8, 2024
Closed
This was referenced Aug 16, 2024
Closed
Closed
This was referenced Aug 24, 2024
Closed
Closed
This was referenced Sep 1, 2024
Closed
Closed
Closed
Closed
@tobistudio tobistudio mentioned this pull request Sep 10, 2024
Closed
This was referenced Sep 24, 2024
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelmtzinf miguelmtzinf miguelmtzinf approved these changes

@kyzia551 kyzia551 kyzia551 left review comments

@The-3D The-3D Awaiting requested review from The-3D

@stevenvaleri stevenvaleri Awaiting requested review from stevenvaleri

@foodaka foodaka Awaiting requested review from foodaka

@kartojal kartojal Awaiting requested review from kartojal

@Zer0dot Zer0dot Awaiting requested review from Zer0dot

@donosonaumczuk donosonaumczuk Awaiting requested review from donosonaumczuk

@BenSparksCode BenSparksCode Awaiting requested review from BenSparksCode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in IPool.sol
5 participants
@Bojidar00 @miguelmtzinf @The-3D @kyzia551 @ga-reth