Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add in ipfs preview page #1921

Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix: add in ipfs preview page #1921

merged 1 commit into from
Jan 26, 2024

Conversation

grothem
Copy link
Collaborator

@grothem grothem commented Jan 25, 2024

General Changes

  • Adds in the ipfs preview page. This was lost during the gov v3 refactor.
  • Fixes an issue where the raw ipfs link on the proposal details page wasn't working

New page is at /governance/ipfs-preview/?ipfsHash=0x0...
Can test this out using some of these ipfs hashes:

0x3dffd2f1b7a87a3f44ab31d0da89e5b64a6258468843c4599edd4527a4cd8c3a
0xb87ef765d6082f5ac26466bc730b069c42d4ea9fe130250a26be627ac259d259
0xbaf47f585bee303606be09f9f9c4215875e8ab48df280c5cabebb94d722a5dd2
0xb33d9ebd247cdfb3e2dee839f082a113b74b4c849c90aa6212531741b6c2b82d
0x57dec17b5950c76b33917a2ff61784a85c796c9fc061e91d313b3fc8a23e6ecf
0x6f9c36de2cb41a1fadfe2f679c47eba6ac4c735de8ee12d3fa5b0d2b6fc3e29e
0xa9b79871f27b840c5d04672f5b2ef16c753938cb80c6809087c1a47ad0fa2880
0x7daf1c990ca47b29e121845efc40ac7e4384b70536f2dee46dd06d4e03920d4c
0x552721cffc5278357af7de0861cbf8a493488c64ec112cf573b9a33623602b90
0xf92585de2ff0761e3d86d0e3253d2f49b2a916ef63784834f5e7230efb1bd194

Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

  • The base branch is set to main
  • The title is using Conventional Commit formatting
  • The Github issue has been linked to the PR in the Development section
  • The General Changes section has been filled out
  • Developer Notes have been added (optional)

If the PR is ready for review:

  • The PR is in Open state and not in Draft mode
  • The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code style generally follows existing patterns
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • Code changes have been quality checked in the ephemeral URL
  • QA verification has been completed
  • There are two or more approvals from the core team
  • Squash and merge has been checked

Copy link

height bot commented Jan 25, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@grothem grothem added Ready for QA Review Ready for QA engineer reviews Ready for Dev Review Read for frontend engineer reviews labels Jan 25, 2024
Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 521.13 KB (🟡 +3 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load
/governance/ipfs-preview 111.34 KB 632.47 KB

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 91.98 KB (-1 B) 613.1 KB
/governance 100.54 KB (🟡 +457 B) 621.66 KB
/governance/v3/proposal 140.83 KB (🟡 +1010 B) 661.95 KB
/reserve-overview 40.39 KB (-1 B) 561.52 KB
/staking 37.04 KB (🟢 -183 B) 558.17 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

@MareskoY MareskoY added QC Passed and removed Ready for QA Review Ready for QA engineer reviews labels Jan 25, 2024
@grothem grothem merged commit 1d25489 into main Jan 26, 2024
26 checks passed
@grothem grothem deleted the fix/governance branch January 26, 2024 16:58
grothem added a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QC Passed Ready for Dev Review Read for frontend engineer reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants