Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controllers specs #5

Merged
merged 16 commits into from
Aug 24, 2023
Merged

Controllers specs #5

merged 16 commits into from
Aug 24, 2023

Conversation

ab-noori
Copy link
Owner

@ab-noori ab-noori commented Aug 24, 2023

Blog app - controllers specs

🌟Features:

  • - RSpec has been integrated into the project as a gem.
  • - A Request spec directory has been created to cover all controllers.
  • - Each action has been verified for accurate response status, template rendering, and placeholder in the body.
  • - The project requirements have been successfully fulfilled, ensuring testing and validation of controller functionality.

Copy link

@rotimiazeez rotimiazeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ab-noori 👏🏽,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • RSpec gem present in the gemfile 👍🏽
  • index and show actions for User and Post controllers are tested 💯
  • All tests passed ✔️
  • Descriptive PR and README 👌🏽

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code. Some of them were simply missed by the previous reviewer, and addressing them will improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me(@rotimiazeez) in your question so I can receive the notification.


As described in the Code reviews limits policy, you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

Copy link
Owner Author

@ab-noori ab-noori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rotimiazeez 👋,
Thank you so much 🙏 for reviewing and approving my pull request.
Your nice feedback is really appreciated 🙏.

Thank-You-Very-Much

@ab-noori ab-noori merged commit f89d770 into dev Aug 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants