Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the new Google Identity Services library #473

Merged

Conversation

Jonnyprof
Copy link
Contributor

  • Change google endpoint
  • Change entity to load
  • Minor eslint fixes

closes #442

PS: Please test it!

@rafa-suagu
Copy link

@jaibatrik can you check this PR please?

@mandziukvlad
Copy link

mandziukvlad commented Feb 28, 2022

No need to test it.

apis.google.com/js/platform.js
apis.google.com/js/client.js
are modules of Google API Client Library aka gapi.client (apis.google.com/js/api.js) which are already being used here and they are not a part of Google Identity Services.

You can read how to migrate to a new library here
Or if you want to see how to use it go here

@Jonnyprof
Copy link
Contributor Author

Yes, I've followed the migration guide and the example from Google API Client Library for JavaScript (https://github.com/google/google-api-javascript-client/blob/master/docs/samples.md#authorizing-and-making-authorized-requests)

@smotornyuk
Copy link

smotornyuk commented Feb 28, 2022

Probably, you've used an outdated guide. Look at this line.
You are using the old library from apis.google.com. Here you can find an example explicitly stating that it's an "old style"

In the new style you should use accounts.google.com

@Julien57970
Copy link

Can someone fix it and merge the PR plz ? Because we need to migrate before the 31st of March, I just receive a mail from Google about it.
"Our announced plan earlier this month stated that authorization support for the Google Sign-In JavaScript platform library will no longer be supported after March 31, 2023."

@hheexx
Copy link
Contributor

hheexx commented Mar 10, 2022

@Julien57970 dude, you have whole year left ;)

@Julien57970
Copy link

@hheexx I know but you don't know my C.I.S.O., he's already on my back for this.

@jaibatrik
Copy link
Contributor

Hoping to check this and merge in a few days. Not having E2E tests makes things difficult.

@jaibatrik jaibatrik merged commit d5bf0ac into abacritt:master Mar 20, 2022
@jaibatrik
Copy link
Contributor

This is now published in v4.1.0.

@Androbin
Copy link

https://developers.googleblog.com/2022/03/gis-jsweb-authz-migration.html

If your web pages use the apis.google.com/js/api.js or apis.google.com/js/client.js JavaScript modules to load the Platform Library, you are affected and need to update your existing implementation to use the new Identity Services client library.

@jaibatrik Issue #442 is not resolved by this PR and needs to be reopened.

@jaibatrik
Copy link
Contributor

I'd appreciate if someone sends a PR. I don't think I myself will get time. Let's use issue #489 to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should Migrate to the new Google Identity Services library
8 participants