-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to the new Google Identity Services library #473
Migrate to the new Google Identity Services library #473
Conversation
@jaibatrik can you check this PR please? |
No need to test it. apis.google.com/js/platform.js You can read how to migrate to a new library here |
Yes, I've followed the migration guide and the example from Google API Client Library for JavaScript (https://github.com/google/google-api-javascript-client/blob/master/docs/samples.md#authorizing-and-making-authorized-requests) |
Probably, you've used an outdated guide. Look at this line. In the new style you should use accounts.google.com |
Can someone fix it and merge the PR plz ? Because we need to migrate before the 31st of March, I just receive a mail from Google about it. |
@Julien57970 dude, you have whole year left ;) |
@hheexx I know but you don't know my C.I.S.O., he's already on my back for this. |
Hoping to check this and merge in a few days. Not having E2E tests makes things difficult. |
This is now published in v4.1.0. |
https://developers.googleblog.com/2022/03/gis-jsweb-authz-migration.html
@jaibatrik Issue #442 is not resolved by this PR and needs to be reopened. |
I'd appreciate if someone sends a PR. I don't think I myself will get time. Let's use issue #489 to track this. |
closes #442
PS: Please test it!