Return void on 204 #1021
Merged
Return void on 204 #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsian03
force-pushed
the
response-fix
branch
2 times, most recently
from
0c95fe1
to
0478ee4
Compare
Flicksie
pushed a commit
to PolestarLabs/polaris
that referenced
this pull request
Jan 30, 2021
flav-code
added a commit
to Flavibot/eris
that referenced
this pull request
Jan 13, 2024
feat/fix: Return void on 204 (abalabahaha#1021)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't check if the string is empty or not. This can cause vague errors when returning a 204 endpoint in a command generator for instance.