Attachment type #1358
Open
Attachment type #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolcalcacol
changed the title
|
Is this solely for the attachment type? There is also an attachments map in command interaction. |
|
@Linker-123 Is that better? |
|
Add types for attachment class |
DonovanDMC
added a commit
to DonovanArchive/ErisPRUpdateBot
that referenced
this pull request
May 7, 2022
- rename "main" to "upstream" - add "everything-v10" branch Additions: - abalabahaha/eris#1283 - abalabahaha/eris#1285 - abalabahaha/eris#1332 - abalabahaha/eris#1344 - abalabahaha/eris#1351 - abalabahaha/eris#1355 - abalabahaha/eris#1358 - abalabahaha/eris#1359 - abalabahaha/eris#1363 - abalabahaha/eris#1366 - abalabahaha/eris#1367 - abalabahaha/eris#1368 - abalabahaha/eris#1369 - abalabahaha/eris#1370 Removals: - abalabahaha/eris#1305 - abalabahaha/eris#1314 - abalabahaha/eris#1325
bsian03
requested changes
May 9, 2022
DonovanDMC
reviewed
May 12, 2022
HeadTriXz
suggested changes
May 12, 2022
bsian03
requested changes
May 12, 2022
bsian03
requested changes
May 12, 2022
TTtie
reviewed
May 13, 2022
|
what was the conclusion with the attachments class vs just using objects? |
DonovanDMC
previously requested changes
Jun 1, 2022
DonovanDMC
suggested changes
Jun 30, 2022
|
The interface pre-dates this pr. Before I headed away I was considering merging it but that would mean processing the message to create attachment classes for each attachment |
|
That sounds like the best idea it's either that or rename one of them |
HeadTriXz
suggested changes
Aug 15, 2022
DonovanDMC
approved these changes
Aug 20, 2022
bsian03
requested changes
Nov 18, 2022
coolcalcacol
commented
Jan 20, 2024
Co-authored-by: bsian03 <chharry321@gmail.com> Co-authored-by: TTtie <me@tttie.cz> Co-authored-by: Donovan Daniels <hewwo@yiff.rocks>
coolcalcacol
force-pushed
the
attachments-type
branch
from
b951a15
to
bc79188
Compare
bsian03
requested changes
Oct 21, 2024
| @@ -166,6 +169,12 @@ class Message extends Base { | |||
| this.member = null; | |||
| } | |||
|
|
|||
| if (data.attachments) { | |||
| for (const attachment of data.attachments) { | |||
| this.attachments.add(attachment, this); | |||
There was a problem hiding this comment.
This needs to be able to update/delete, or overwrite completely
There was a problem hiding this comment.
I feel like some of these properties can be modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.