Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway/REST): V10 API changes #1371

Merged
merged 8 commits into from
Jan 5, 2024
Merged

Conversation

coolcalcacol
Copy link
Contributor

Re-created due to github being github

Breaking

  • getActiveThreads has been removed, as the endpoint is no longer available

Additions

  • messageContent intent added
  • all and allPrivileged types and bit fields updated

Changes

  • Gateway/REST version 9 -> 10
  • application.summary type changed from string to explicit ""

TODO:

  • document attachments changes, if anyone cares
  • check if achievements are actually cared about

@bsian03 bsian03 added the Discord label May 9, 2022
DonovanDMC
DonovanDMC previously approved these changes May 11, 2022
Copy link
Contributor

@DonovanDMC DonovanDMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all the current changes are present, LGTM

@frobinsonj
Copy link
Contributor

https://discord.com/developers/docs/change-log#api-v10

To specify a reason for an administrative action in audit logs, apps must now pass the X-Audit-Log-Reason header rather than the reason parameter for all endpoints.

The following should exception should probably be removed:

if((method !== "PUT" || !url.includes("/bans")) && (method !== "POST" || !url.includes("/prune"))) {

Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not doing attachments since Game SDK is out of scope within Eris. Attachment changes were already documented in the previous PR

@bsian03 bsian03 merged commit a331615 into abalabahaha:dev Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants