Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for new audit log events #562

Merged
merged 8 commits into from
Nov 23, 2019
Merged

Adds support for new audit log events #562

merged 8 commits into from
Nov 23, 2019

Conversation

Khaaz
Copy link
Contributor

@Khaaz Khaaz commented Nov 19, 2019 •
edited
Loading

This updates eris according to discord/discord-api-docs#1191.

It adds:

MEMBER_MOVE: 26
MEMBER_DISCONNECT: 27
BOT_ADD: 28

MESSAGE_BULK_DELETE: 73
MESSAGE_PIN: 74
MESSAGE_UNPIN: 75

INTEGRATION_CREATE: 80
INTEGRATION_UPDATE: 81
INTEGRATION_DELETE: 82

This PR also updates the typings.

Skillz4Killz
Skillz4Killz previously approved these changes Nov 19, 2019
View reviewed changes
Skillz4Killz
Skillz4Killz previously approved these changes Nov 19, 2019
View reviewed changes
abalabahaha
abalabahaha requested changes Nov 20, 2019
View reviewed changes
Copy link
Owner

@abalabahaha abalabahaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GuildAuditLogEntry#target getter needs to be updated to return null for integration actions

@Khaaz
Updates GuildAuditLogEntry with new types.
2e425dc 
Return null for target for 26 and 27.
Returns null for target for integrations events
@Khaaz
Copy link
Contributor Author

Khaaz commented Nov 21, 2019 •
edited
Loading

Edit:s
For MEMBER_MOVE and MEMBER_DISCONNECT, the target getter now returns null. discord/discord-api-docs#1195
For INTEGRATION events, the target getter now returns null. discord/discord-api-docs#1194
For INTEGRATION options specified in the issue, they are includes in data.before and data.after so we don't need to expose thoses directly and the current implementation seems to be fine.

I keep a server with integrations for testing if this changes in a near future

abalabahaha
abalabahaha requested changes Nov 21, 2019
View reviewed changes
lib/structures/GuildAuditLogEntry.js Outdated Show resolved Hide resolved
@abalabahaha abalabahaha merged commit 3f87066 into abalabahaha:dev Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalabahaha abalabahaha abalabahaha approved these changes

@Skillz4Killz Skillz4Killz Skillz4Killz left review comments

Assignees
No one assigned
Labels
Discord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Khaaz @abalabahaha @Skillz4Killz