Fix #217 and deprecation warnings on install #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix/workaround for #217.
Resolve deprecation warnings on installation: - Switch to @mapbox/node-pre-gyp, see abandonware/node-bluetooth-hci-socket#26. - Remove dev dependency on eslint-config-semistandard.
Fix deprecation and vulnerability warnings on install.
rzr
approved these changes
Oct 1, 2021
Fix lint errors.
|
I fixed the lint errors, sorry about that. |
|
@rzr, could you please review this PR and let me know if I need to change anything? Thanks. |
|
@rzr, would it be possible to create a new release with this PR? Thanks. |
|
actually, you can do this yourself try to open a new PR with similar changes l made for previous release. ask for help in needed |
|
Hm, didn't know I could. Please see #227. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash of noble / NodeJS when (re-)enabling Bluetooth on a Raspberrry Pi, see #217.
It also addresses the deprecation and vulnerability warnings on install, by switching to @mapbox/node-pre-gyp (cf. abandonware/node-bluetooth-hci-socket#26), by updating the dependencies on node-bluetooth-hci-socket and on eslint-config-semistandard, and by removing the dev dependency on eslint-plugin-standard.
I really appreciate the work you're doing here. Please let met me know how I can help.