Update of DEMO31 as advised in #558 #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set_auto_size needs lo_worksheet->calculate_column_widths( ) to work
AndreaBorgia-Abo
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
Cool! I ran into #646 a while ago and this looks like a compact solution, thanks.
Tested with LibreOffice, by the way.
|
I think ZCL_EXCEL_WRITER_2007->CREATE_XL_SHEET (Row 461) is wrong.
should be changed to:
Same game for ZCL_EXCEL_WRITER_HUGE_FILE (Row 306). |
|
@dbausch85 how is it related to this PR? |
|
@dbausch85 I don't see how your comment is related to this PR, I just changed |
gregorwolf
approved these changes
May 19, 2021
|
Thank you @AlexandreHT for the contribuiton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set_auto_size needs lo_worksheet->calculate_column_widths( ) to work