Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud: extract demo logic to classes? #69

Merged
merged 6 commits into from
Sep 6, 2024
Merged

cloud: extract demo logic to classes? #69

merged 6 commits into from
Sep 6, 2024

Conversation

larshp
Copy link
Member

@larshp larshp commented Aug 7, 2024

hi,
any thoughts on extracting the demo logic to classes? this way the class will syntactically be ABAP Cloud Programming Model compatible

I've created an interface for output demos, guess there are also input demos, but starting here

folder is named /oo/ which I dont like but I dont have any good ideas

@sandraros
Copy link
Collaborator

I agree to migrate the code to classes as you propose (especially to target whay you say: "then one day it should be possible to have github actions automatically generate the xlsx files, and check/show differences if any").

I wouldn't create a separate folder for only classes, all can be in the same folder, but I agree that there are too many objects in one folder. Just to say, if one folder is to be created, to reduce the number of files, I'd first go to move the zdemo_excel_checker stuff (Web Repository files).

@larshp
Copy link
Member Author

larshp commented Aug 26, 2024

folder removed, can always move things around

@larshp larshp merged commit 5a3963e into main Sep 6, 2024
2 checks passed
@larshp larshp deleted the hvam/cloud0708 branch September 6, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants