handle dependencies from abaplint.json

[JohannesKonings]

handle dependencies from abaplint.json #27

The most is copy paste from the abaplint CLI (https://github.com/abaplint/abaplint/blob/master/packages/cli/src/cli.ts#L87).
It works for my test case https://github.com/JohannesKonings/test-abaplint-interface.

Recommendations welcome :)

[larshp]

looks like server/src/compressed_file.ts can be deleted, the compression stuff is not triggered, and don't think its needed for this scenario

[g-back]

can leave out the function argument if you use arrow functions instead of "function" keyword:

private async addDependencies() {
    const deps = this.reg.getConfig().get().dependencies;
    if (deps) {
      deps.forEach((dep) => {
        (async () => {
          process.stderr.write("Clone: " + dep.url + "\n");
          const dir = fs.mkdtempSync(path.join(os.tmpdir(), "abaplint-"));
          childProcess.execSync("git clone --quiet --depth 1 " + dep.url + " .", {cwd: dir, stdio: "inherit"});
          const names = FileOperations.loadFileNames(dir + dep.files);
          let files: abaplint.IFile[] = [];
          files = files.concat(await FileOperations.loadFiles(false, names));
          files.forEach((file) => {
            this.reg.addFile(new abaplint.MemoryFile(file.getFilename(), file.getRaw()));
          });
          FileOperations.deleteFolderRecursive(dir);
        })();
      });
    }
  }

[JohannesKonings]

yes, I changed it to the fat arrow

[g-back]

thanks, now you can leave out the registry as a function argument, instead:

private async addDependencies() 

and

     await this.addDependencies(); 

[JohannesKonings]

Hopefully I get you right :).
I deleted the async/await.

[JohannesKonings]

now I get it. I removed the registry as a function argument

[JohannesKonings]

added async/await again with leave out the registry as a function argument.

[JohannesKonings]

@larshp I deleted everthing regarding server/src/compressed_file.ts

[larshp]

thanks, lets try this 👍