-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Godot 4 support? #98
Comments
As I understand it, only stable releases are planned to be supported by godot-ci. As a result, Godot 4 will only be supported once 4.0 stable is released. |
Yes, as Calinou mentioned, we do not see value in supporting non-stable releases, as that would add unnecessary overhead to the contributors. However I have personally made images off of betas and alphas before, so it is very possible and easy (just change the download path). Let me know if you have difficulty with this. |
Any updates? Godot 4 is stable now. |
No headless binary for now, which is needed for this image to work afaik. |
There's no headless binary anymore for Godot 4. The Windows, Mac, and Linux binaries now have a headless mode that's activated when ran with the |
Support for Godot 4.0 was added as a release tag yesterday. 🎉 |
Hold on @realkotob, the current release of Godot CI 4.0 is broken! It even failed the action for the tag: https://github.com/abarichello/godot-ci/actions/runs/4309001784 . The fact is that the dedicated Linux headless binary is gone and needs to be adjusted in the Dockerfile, maybe PR #104 is still relevant? |
Hey guys, just to confirm, this: https://hub.docker.com/r/barichello/godot-ci will be updated to the 4.0 stable as soon as the problem is fixed? Thanks! |
This PR has been merged so things should be fixed now |
But there is no Docker image because the action didn't run as the release tag already exists ? |
I put together a PR for helping complete the support for Godot 4 (#105). Hoping this can help. Let me know if there is anything I can do to help further. Thanks~ |
Seems like there still isn't a Godot 4 image available. Any updates? |
See #107. It seems that not even 3.5.2 is listed on https://hub.docker.com/r/barichello/godot-ci, so I guess the automated deployment that was merged in #79 isn't working. cc @TheOrioli |
The check releases is working correctly, but it seems that the current Dockerfile is incorrect, see workflow: To fix 3.5.2 missing, someone with maintainer access to the repository needs to run the Manual Workflow, but first the issue with the Dockerfile should be fixed. Unfortunately, I currently do not have the capacity to take a look at it. What I can suggest for Godot 4 CI builds is https://github.com/chickensoft-games/setup-godot I've been using it successfully on our latest project. |
Looks like you can just use the official Godot one, and sunset this repo https://github.com/godotengine/godot-build-scripts |
From
|
I believe #107 has those fixes you're referring to - it was merged 2 weeks after that failed run which 404'd looking for a bad URL (the
I'm one of those people looking for 3.5.2 support 🥲 Anyone that could help? |
I've triggered a workflow run for |
@Mawdac
Seems the build worked🎊 Can you confirm your CI stuff is now operational? |
Can confirm my CI stuff is "working"! (It is able to pull down and use the 3.5.2 docker image 🥳 but it's failing for other reasons specific to my project, somewhat like this - #48 (comment) - might open a discussion while debugging that later 😄) Thank you @Calinou @TheOrioli for the quick build and replies! |
Does this mean 4 will never be supported and instead should use the link provided? Or would this here be better? https://github.com/marketplace/actions/godot-export |
Any chance we will see GoDot 4 support soon?
The text was updated successfully, but these errors were encountered: