Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature ID warning message #57

Closed
agalperina opened this issue Aug 31, 2021 · 3 comments
Closed

feature ID warning message #57

agalperina opened this issue Aug 31, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@agalperina
Copy link

It would be great to get a warning message when the feature IDs of the assay table do not match the feature IDs in the feature table.

@jdblischak
Copy link
Contributor

@agalperina Could you please provide an example or some more context where this issue arose? At what step did you expect to see a warning? When a study package is created, OmicNavigator validates that all the feature IDs in the assays table are present in the features table.

@agalperina
Copy link
Author

@jdblischak in a recent study I came across a scenario where the IDs in the assay and features tables were different. The study uploaded successfully but I think it might be nice to get a warning message when you are installing a study that lets the uploader know that the IDs do not match.

@bengalengel bengalengel added the bug Something isn't working label Sep 2, 2021
jdblischak added a commit to abbvie-external/OmicNavigator that referenced this issue Sep 3, 2021
@jdblischak
Copy link
Contributor

Bug fixed in abbvie-external/OmicNavigator@260f71d. Now addAssays() will throw an error if any of the assays tables has a non-numeric column.

Thanks @agalperina for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants