[DO NOT MERGE YET] Fix HID Bootloader #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed in f0c5dfe. |
NicoHood
commented
Jan 7, 2018
| uint32_t PageAddress = ((uint32_t)Endpoint_Read_16_LE() << 8); | ||
| #else | ||
| uint16_t PageAddress = Endpoint_Read_16_LE(); | ||
| #endif | ||
|
|
||
| /* Check if the command is a program page command, or a start application command */ | ||
| #if (FLASHEND > 0xFFFF) | ||
| #if (FLASHEND > USHRT_MAX) |
There was a problem hiding this comment.
@abcminiuser Why didnt you pickup this line of fix?
There was a problem hiding this comment.
They're equivalent, no? I prefer the explicit constant since the constraint isn't the type but the device's actual memory layout, but I suppose the named value works just as well.
There was a problem hiding this comment.
Yes, just keep it. Its fine and should be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
The clock divider is not essential, but I just added it as in the other bootloader sketch.
You could compact the code a bit more and more the check upwards and save the reg before. I just wanted to keep an better overview though.
See this for more information:
http://www.nongnu.org/avr-libc/user-manual/group__avr__watchdog.html
Edit:
Do not merge this PR yet. I will update a few more things and comment when its ready.