Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra mp4 and add TypeScript decs #220

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Remove extra mp4 and add TypeScript decs #220

merged 1 commit into from
Jan 26, 2024

Conversation

phocks
Copy link
Member

@phocks phocks commented Jan 26, 2024

Just adding TypeScript declarations so that VS Code stops yelling at me.

AshKyd
AshKyd reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@AshKyd AshKyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I noticed that too. I think I caused this problem in the first place

@phocks
Copy link
Member Author

phocks commented Jan 26, 2024

Na I think you just need to add the declarations when you add other files to webpack. All good. Will merge.

@phocks phocks merged commit 8c50d2b into main Jan 26, 2024
3 checks passed
@phocks phocks deleted the typescript-webp-declare branch January 26, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshKyd AshKyd AshKyd approved these changes

@drzax drzax Awaiting requested review from drzax

@katiaeirin katiaeirin Awaiting requested review from katiaeirin

@jtfell jtfell Awaiting requested review from jtfell

@andrewkesper andrewkesper Awaiting requested review from andrewkesper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phocks @AshKyd