-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test reusable workflow in e2e test #136
Conversation
Added @bradegler and @verbanicm as reviewers to get some input on the terraform code as they are the experts. |
Please correct me if I am wrong, you want to test both reusable workflows (upload file to gcs via reusable workflow) and code logic (manually upload file to gcs) on whatever code changes. It seems redundant. We can test reusable workflow when there are changes to them, if no changes to these workflow files then test the code logic. Therefore, we can have a separate workflow to test reusable workflow. Also smaller PRs are preferred. Another way is to test reusable workflow -> only check if files successfully uploaded to gcs in ci, test the entire e2e in dev when doing the release, this way we don't need to change the current ci infrastructure. Only concern is what if e2e fail, we need to fix it asap and release a new version. Just my thoughts, I will wait for other people's review. |
The idea for this update is to ensure the workflow's behavior is correct. According to previous discuss with Chen, we decide to add this to the CI e2e test.
I don't think I can further break down this PR, as calling a reusable workflow in
The current way we can test all the things in ci project, and the current set up can ensure the env are cleaned up after test is running, these are the reason I implemented this way. |
f56fcd7
to
8e54799
Compare
e87780b
to
989deae
Compare
989deae
to
da24777
Compare
da24777
to
55e74f4
Compare
0bd6e9f
to
a26f6e5
Compare
a26f6e5
to
117657c
Compare
117657c
to
0d08701
Compare
fix: #128