Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: update errors from protoutil.FromYAML() as user facing error #150

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Fix: update errors from protoutil.FromYAML() as user facing error #150

merged 5 commits into from
Jul 12, 2023

Conversation

sailorlqh
Copy link
Contributor

fix: #149

@sailorlqh sailorlqh requested a review from a team as a code owner July 12, 2023 00:52
@sailorlqh sailorlqh requested review from drevell, pdewilde, yolocs and capri-xiyue and removed request for drevell and pdewilde July 12, 2023 00:52
@sailorlqh sailorlqh requested a review from sqin2019 July 12, 2023 01:00
capri-xiyue
capri-xiyue reviewed Jul 12, 2023
View reviewed changes
pkg/server/event_handler_test.go Show resolved Hide resolved
pkg/server/event_handler.go Outdated Show resolved Hide resolved
yolocs
yolocs reviewed Jul 12, 2023
View reviewed changes
pkg/server/event_handler.go Outdated Show resolved Hide resolved
pkg/server/event_handler_test.go Show resolved Hide resolved
yolocs
yolocs previously approved these changes Jul 12, 2023
View reviewed changes
pkg/server/event_handler_test.go Outdated Show resolved Hide resolved
capri-xiyue
capri-xiyue previously approved these changes Jul 12, 2023
View reviewed changes
@sailorlqh @yolocs
Update pkg/server/event_handler_test.go
1ed5743 
Co-authored-by: Chen Shou <cshou@google.com>
Signed-off-by: Qinhang Li <55097418+sailorlqh@users.noreply.github.com>
@sailorlqh sailorlqh dismissed stale reviews from capri-xiyue and yolocs via 1ed5743 July 12, 2023 22:48
@sailorlqh sailorlqh merged commit 8e6f39f into main Jul 12, 2023
@sailorlqh sailorlqh deleted the sailorlqh/fix_yaml_retry branch July 12, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yolocs yolocs yolocs approved these changes

@capri-xiyue capri-xiyue capri-xiyue approved these changes

@sqin2019 sqin2019 Awaiting requested review from sqin2019

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proto unmarshal error will keep retrying in the pmap service
3 participants
@sailorlqh @yolocs @capri-xiyue