refactor: move gcs upload and bq query functions to testutil #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h e2e test and prober can use them
capri-xiyue
requested changes
Jul 26, 2023
capri-xiyue
reviewed
Jul 26, 2023
yolocs
reviewed
Jul 26, 2023
yolocs
reviewed
Jul 26, 2023
sethvargo
reviewed
Jul 27, 2023
yolocs
reviewed
Jul 27, 2023
yolocs
previously approved these changes
Jul 27, 2023
capri-xiyue
reviewed
Jul 27, 2023
capri-xiyue
approved these changes
Jul 27, 2023
yolocs
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move gcs upload and bq query functions to testutil as they can be used by both integration test and prober.