feat: update goreleaser for prober #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yolocs
requested changes
Aug 1, 2023
capri-xiyue
reviewed
Aug 2, 2023
yolocs
requested changes
Aug 2, 2023
sailorlqh
force-pushed
the
sailorlqh/add_prober_docker_release
branch
from
c5a0807
to
798089e
Compare
yolocs
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
docker.goreleaser.yamlis also used by theciworkflow, so it will build prober images whenciworkflow is triggered. However we don't really need a prober in theciproject.We can create a ci dedicated
ci.docker.goreleaser.yamlas a follow up if we think the current solution is not tolerable. My personal opinion is the current way is tolerable, having one yaml for bothreleaseandciworkflow to use is better than maintaining two similar yaml files.