chore:switch to pmap new projects #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capri-xiyue
requested review from
sqin2019,
sailorlqh and
yolocs
and removed request for
sailorlqh and
ruizhg
sailorlqh
previously approved these changes
Sep 11, 2023
sqin2019
reviewed
Sep 11, 2023
|
The CI/CD is blocked by some CI/CD infra set up |
This is strange, looking at the error log, it is in the gha-pmap-ci-i-f49bd9 project? It is for WIF reousrces therefore we shouldnt need pubsub there. |
I think it is because if the WIF need to create some pubsub resources in another project, the project which includes WIF should also enable pubsub apis. |
yolocs
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch to pmap new projects