Conditionally handle IE11 in 'Download' component #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umar-khan
force-pushed
the
ie11-download-component
branch
from
ed977a1 to
c742cef
Compare
|
I think this will be a useful addition to support download on IE11 since the change to using blob. However can you add tests for it. @umar-khan Maybe in your test, define then delete the presence of
|
mriccid
force-pushed
the
master
branch
2 times, most recently
from
4c691cb to
f129262
Compare
|
@umar-khan can you confirm if this is still an issue in v1.1.2? |
abdennour
requested changes
Dec 20, 2021
| ); | ||
| const {data, headers, separator, uFEFF, target, specs, replace, filename} = this.props; | ||
|
|
||
| if (window.navigator.msSaveOrOpenBlob) { |
There was a problem hiding this comment.
Great feature! But unit-tests are required for this block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the
Download.jscomponent does not work on IE11.Instead of downloading the file, it asks the user to choose an app to open the
blobfile.Changes
Update the
componentDidMount()method inDownload.jsto check ifwindow.navigatorhas amsSaveOrOpenBlobmethod. This method should only be available on IE so it shouldn't other users.If
msSaveOrOpenBlobexists, we use themsSaveBlobto download the file.This functionality should be consistent with
Link.jscomponent.Steps to Reproduce
I'm able to reproduce this consistently using IE11 on Windows 10.
Download.jsmount after a specific action (this should trigger the file download to begin).componentDidMount()in theDownload.jscomponent triggerswindow.openwhich opens a new window.allow this website to open an app.Allowthey are prompted to choose an app to open theblobfile.