Skip to content

Conversation

marudy
Copy link

@marudy marudy commented Sep 28, 2018

Add typed definitions generated from Microsoft/dts-gen. Then added manually prop types for CSVLink component.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.609% when pulling ad4c3bf on marudy:master into dbc0467 on abdennour:master.

@abdennour
Copy link
Collaborator

If someone is interested in being a contributor in this project, please let contact me.

While it's hard to review all issues/PR due to time limitation, it is also not acceptable to approve PRs without review.

@mriccid
Copy link
Collaborator

mriccid commented Nov 9, 2018

Thanks for your contribution. I'm not too familiar with TypeScript, but it seems like the output from dts-gen should be used as the basis for the type definitions. How much more work would be required to complete these type definitions? My main concern is the number of anys in the types.

@mriccid mriccid force-pushed the master branch 2 times, most recently from 4c691cb to f129262 Compare February 5, 2019 05:12
@mccabemj
Copy link
Collaborator

mccabemj commented Feb 5, 2019

Agree with @mriccid. This seems like an output straight from dts-gen and needs work

@mccabemj mccabemj closed this Feb 5, 2019
@marudy
Copy link
Author

marudy commented Feb 5, 2019

Hi there @mriccid, @mccabemj,

sorry for the late reply. This typed definitions here are the result of dts-gen along with some customization so that TS compiler won't complain. At this stage it's not accurate but it could probably be used as basis. If someone would like to pick it up and continue feel free :) as my time is super limited during this period.

Cheers,
Tasos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants