Skip to content

Conversation

BlissfulDarkness
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-9.09%) to 90.909% when pulling bc64c24 on PointInside:master into cab05da on abdennour:master.

bmuenzenmeyer added a commit to bmuenzenmeyer/react-csv that referenced this pull request Nov 17, 2017
@bmuenzenmeyer
Copy link

Tested this - works as expected.

@abdennour any hope we can get this merged in? I'd hate to have to fork and publish a separate repo with updates

@abdennour
Copy link
Collaborator

Please fix failed unit-tests before?

@BlissfulDarkness
Copy link
Collaborator Author

This does not break the unit tests. Coverage decreased due to the IE11 code workaround, which can only be tested in IE11, since it is a browser specific anomaly. Manual testing has been performed, both by us and the community as indicated in this PR, and we use this in our production customer portal which requires IE11 support.

Our options are either to maintain our own fork, which is silly for the amount of code changed or stop using this component, because we cannot lock ourselves to an old and unsupported version of our components.

Because this has been open for so long, we are accumulating merge conflicts from the CDN versions. According to your own documentation, coverage must be above 80%, which is true for this PR.

@abdennour
Copy link
Collaborator

Thank you @hindmanj for the swift response . If you could resolve conflict I will be more than happy. Also I will add you as collaborator in github , but I need also your NPM username to add you there.

@abdennour
Copy link
Collaborator

@hindmanj also "lib" directory needs to be ignored . However , it will be considered in the NPM.

@abdennour
Copy link
Collaborator

Once you are done. Please notify me here

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.5%) to 91.549% when pulling 512ad44 on PointInside:master into 8b2db44 on abdennour:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants