-
-
Notifications
You must be signed in to change notification settings - Fork 263
Fix for PR Network Failed in Chrome with large files #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
window.navigator.msSaveBlob(blob, filename) | ||
|
||
return false | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handleLegacy
is responsible for handling cases where the anchor element's href
attribute cannot be used to trigger the download. This else
block is unnecessary as we could just move this logic to the buildURI
function and have it return that straight to the href
attribute on line 58. That would reduce the complexity of the changes from this PR which would subsequently make it easier for the code coverage to remain above 90%.
Let me know if you are able to make those changes, otherwise I am happy to implement them myself in a new PR (as I have been meaning to do)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Arguably the function should be renamed, since the function's purpose is to support IE11, which requires us to use msSaveBlob, as it doesn't support href="data:"
Hey! just wondering what the current status is for getting this merged in? thanks |
@athurman if the changes requested above are made and the test coverage is not negatively affected then I would be happy for this to be merged in and released. |
Please could anyone let me know when the problem will get fixed?? |
I've started on a PR to fix this problem because I don't think this PR is moving. I need to fix a few small issues with it and ensure that the build passes, then will get it merged |
4c691cb
to
f129262
Compare
As far as I can see, this was dealt with in #73 |
Fixes (#44,#62)
Solution to @mickbalaban's PR