Use CSVLink to allow filename for CSVDownload #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdennour
requested changes
Mar 7, 2018
There was a problem hiding this comment.
Thank you @Jarvis1010 This is a great feature. CSVLink will be the main component and it will ease the maintenance of CSVDownload component. I have only one concern. Indeed, any file under ""cdn/" folder should appear in the pull-request since CDN will be generated just before shippment to NPM
|
@Jarvis1010 can you update this PR to fix/change failing unit tests and conflicts? I think it would be a good thing to get merged |
Jarvis1010
force-pushed
the
master
branch
2 times, most recently
from
fba7ac1 to
ce74cd1
Compare
|
Updated and CI working but coverage has decreased |
It resolves react-csv#64
Changelog: - Fixes react-csv#97
Added documentation to support nested JSON data Added test for dot notation in headers
It resolves react-csv#64
|
@abdennour @mccabemj I have resolved the merge conflicts in this PR here: #129 |
|
#137 has these changes, along with fixes to unit tests, and without spurious style changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just merged with the latest commits, I believe this should be correct now