Allowing falsy entries in json data #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2017 15:15
* Replaced '99' with a numerical 0 * react-csv#6
* `header in object` should be a sufficient condition. The suggested `String(object[header])` wasn't passing the original tests - it caused keys that didn't exist on the object to be inserted as undefined. Checking if the key is in the object allows for falsy values, while preventing keys that haven't ever been set from leaking in. * Should close issue react-csv#6 * react-csv#6
abdennour
reviewed
Mar 12, 2017
| headers.map((header) => | ||
| object[header] ? object[header] : ''))] | ||
| headers = headers || jsonsHeaders(jsons); | ||
| const data = jsons.map((object) => headers.map((header) => (header in object) ? object[header] : '')); |
There was a problem hiding this comment.
I like it.. yes this is the best solution or also object.hasOwnProperty(header)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues #6