-
-
Notifications
You must be signed in to change notification settings - Fork 263
Escape double quotes in csv #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR would be useful for my current project. |
@clodal can you fix the conflicting files so I can review for merge? |
I'd love to see this indeed very useful feature in react-csv, too. Currently I do some character conversion/masking when collecting the data, but the cleaner solution would be to have this feature included in this lib. |
I'd prefer to modify |
07e45d1
to
6e42eaa
Compare
4c691cb
to
f129262
Compare
Do we think this is still needed with PR #74 in? If the prop
Shall we conditionally look at the passed in |
I vote for conditionally look at the |
Alright, closing PR then! Thanks |
Released with react-csv@2.2.1 |
Related to #28
'<h1 style="text-align:center;">example</h1>'
by escaping double quotes as set out in rfc4180.Look forward to your feedback. Thank you!