Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow #40 #41

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Follow #40 #41

merged 1 commit into from
Dec 9, 2022

Conversation

Naville
Copy link
Contributor

@Naville Naville commented Dec 9, 2022

No description provided.

@Naville Naville mentioned this pull request Dec 9, 2022
@abdes abdes added the bug Something isn't working label Dec 9, 2022
@abdes abdes self-requested a review December 9, 2022 18:11
@Naville
Copy link
Contributor Author

Naville commented Dec 9, 2022

@abdes Could you possibly re-tag 8.7.0? My downstream depends on it

@abdes
Copy link
Owner

abdes commented Dec 9, 2022

@abdes Could you possibly re-tag 8.7.0? My downstream depends on it

Well, it's a bit problematic to re-tag with the same tag name.

My understanding is that Git does not (and it should not) change tags behind users back. So if somebody already got the old tag, doing a git pull on cryptopp-cmake shouldn’t just make them overwrite the old one.

The sane principle I usually follow is: people MUST be able to trust their tag-names. This is why, as documented in README.md, it is possible that we make new tags for cryptopp-cmake while keeping the same version of crypto++ but with a new tag name.

Would that work for you? A new tag CRYPTOPP_8_7_0_a for example?

@Naville
Copy link
Contributor Author

Naville commented Dec 9, 2022

or, I purpose a new mechanism if things broken again, basically CRYPTOPP_8_7_0_0/1/2/...., most of the time there is only _0 variant, which we can probably ignore and just use CRYPTOPP_8_7_0

@abdes
Copy link
Owner

abdes commented Dec 9, 2022

@noloader really insisted on exactly CRYPTOPP_M_m_p being the initial one for smooth transition from the old project. We can however use _1/2/3/... for subsequent ones.

Tag CRYPTOPP_8_7_0_1 incoming...

List of fixes included are documented in #26, none of them introduces any backward incompatibility.

@abdes
Copy link
Owner

abdes commented Dec 9, 2022

Done.
https://github.com/abdes/cryptopp-cmake/releases/tag/CRYPTOPP_8_7_0_1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants