Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch content #85

Merged
merged 11 commits into from
May 26, 2023
Merged

Fetch content #85

merged 11 commits into from
May 26, 2023

Conversation

Vollstrecker
Copy link
Collaborator

Conversion completed (including master with http)

@Vollstrecker Vollstrecker linked an issue May 25, 2023 that may be closed by this pull request
convert source-download to fetchcontent #75
Closed
@abdes
Copy link
Owner

abdes commented May 25, 2023

@Vollstrecker Can you review this PR again?
There is an issue with CRYPTOPP_PROJECT_DIR I think... Please keep everything consistent, you either keep that variable as is and make it the only one used everywhere, or if you also use cruptopp_SOURCE_DIR, then make it the only one used everywhere.

@Vollstrecker
Copy link
Collaborator Author

Seems like the merge has changed back 3 lines. Should be fixed now.

@abdes abdes merged commit 0f506cf into master May 26, 2023
@abdes abdes mentioned this pull request Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

convert source-download to fetchcontent
2 participants
@Vollstrecker @abdes