Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to load the tablr package #50

Closed
esjay opened this issue May 2, 2016 · 3 comments
Closed

Failed to load the tablr package #50

esjay opened this issue May 2, 2016 · 3 comments
Labels

Comments

@esjay
Copy link

esjay commented May 2, 2016

  1. Choose the Seti UI theme
  2. Receive stack trace error.

Atom Version: 1.7.3
System: Mac OS X 10.11.4
Thrown From: tablr package, v1.2.3

Stack Trace

Failed to load the tablr package

At .btn is undefined in /Users/wayne/.atom/packages/tablr/styles/tablr.less:896:12

LessError: .btn is undefined
  at /Users/wayne/.atom/packages/tablr/styles/tablr.less:896:12

Commands

Config

{
  "core": {
    "disabledPackages": [
      "linter-flake8",
      "node-resolver",
      "linter-jshint",
      "js-autoimport"
    ],
    "themes": [
      "seti-ui",
      "an-old-hope-syntax"
    ]
  }
}

Installed Packages

# User
an-old-hope-syntax, v0.5.0
angularjs, v0.3.4
atom-django, v0.3.2
atom-handlebars, v1.3.0
atom-ternjs, v0.14.1
atom-typescript, v8.9.1
auto-run, v0.2.1
autocomplete-modules, v1.4.1
browser-plus, v0.0.60
color-picker, v2.1.1
editorconfig, v1.4.1
hyperclick, v0.0.36
js-hyperclick, v1.4.2
language-diff, v0.4.0
language-javascript-jsx, v0.3.7
language-python-django-templates, v0.1.0
linter, v1.11.4
linter-doiuse, v0.2.3
linter-eslint, v7.2.1
linter-js-yaml, v1.2.5
linter-jsonlint, v1.2.5
linter-less, v2.5.0
linter-tidy, v2.1.0
minimap, v4.23.2
minimap-autohide, v0.10.1
minimap-bookmarks, v0.3.0
minimap-find-and-replace, v4.5.1
minimap-git-diff, v4.3.0
minimap-pigments, v0.2.0
pigments, v0.26.0
pretty-json, v1.0.3
project-manager, v2.9.7
seti-ui, v1.0.3
sync-settings, v0.7.2
tablr, v1.2.3
tabs-to-spaces, v1.0.2
tool-bar, v0.4.0
webbox-color, v0.5.9

# Dev
No dev packages
@esjay
Copy link
Author

esjay commented May 2, 2016

Updated issue to note that Seti UI theme seems to be a necessary step in recreating this specific issue.

@abe33
Copy link
Owner

abe33 commented May 3, 2016

Hi @esjay,

Yep, it looks like the Seti UI theme only define button.btn instead of just .btn which make the tablr unable to extend the button styles. I'll see if I can find a way around that, and open a ticket on Seti UI Theme to see if we can find a better solution.

@abe33 abe33 added the bug label May 3, 2016
abe33 added a commit to abe33/seti-ui that referenced this issue May 3, 2016
As noticed with abe33/atom-tablr#50 since the button's rule is defined using `button.btn` it's not possible to neither extend the style in less nor to apply a button style to another type of node. I feel this should not be enforced by the theme since there's some case where a button can't be used.

In my case I'm making `label` following a `input[type="radio"]` extend `.btn` on `label` in a radio group to create a toggle buttons bar in the CSV settings: 

![](https://raw.githubusercontent.com/abe33/atom-tablr/gh-pages/csv-opener.png)
https://github.com/abe33/atom-tablr/blob/master/styles/tablr.less#L920-L922
@abe33
Copy link
Owner

abe33 commented May 10, 2016

Since my PR on Seti UI was merged and published, I'll be closing that issue, feel free to open a new issue if you find another problem with a theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants