-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #181
Update README.md #181
Conversation
change the color of Abell white to Black look it look more attractive and fix 1-2 typo error
@saurabhdaware please check my PR and merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi thanks for putting in the effort but doesn't seem like this PR is helpful 😢
If this is your first hacktoberfest and you're learning to send PRs. I would say don't be discouraged by rejection. It's usually recommended to have more meaningful contributions that help the project.
To avoid extra efforts, I'll recommend creating the issue and discussing change if you're unsure about the enhancements.
Let me know if you're interested in learning about open-source and have any particular questions, I'll be happy to help.
Unfortunately I won't be able to accept this PR
<picture> | ||
<source media="(prefers-color-scheme: dark)" srcset="https://github.com/abelljs/abell/assets/30949385/0452e85b-df57-47a3-891c-33068de5c0e2"> | ||
<source media="(prefers-color-scheme: light)" srcset="https://github.com/abelljs/abell/assets/30949385/e9ea17d6-c248-4ef6-9803-fd058b131b4a"> | ||
<img width="512" alt="Abell Logo and Title" src="https://github.com/abelljs/abell/assets/30949385/e9ea17d6-c248-4ef6-9803-fd058b131b4a"> | ||
</picture> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
**Documentation:** https://abelljs.org | ||
|
||
**Documentation:** [https://abelljs.org](https://abelljs.org) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed since GitHub automatically linkifies the https links
<!-- Animated Element --> | ||
![Abell in Action](https://example.com/animated-demo.gif) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't seem to do anything 😅
Description
change the color of Abell from white to Black look it looks more attractive and fix 1-2 typo error
Added unit tests?
[optional] Random GIF to +1 someone's day