feat: retries if default port is occupied #64
Conversation
|
I will add tests soon then this will be ready for merge |
No, I think this way is much better than having a prompt. |
|
P.S. Arrow is suchaa cutieeeee!!! When you all celebrate his birthday or any other day for him, is it called Arrow Function :p ? |
|
Re P.S. : haha, his birthday is on 7th July My brother actually named him from the TV series Arrows. First time I have linked him with js arrow fns because of you 😅. |
|
Hold up, we have no tests for dev server 😅 |
|
oh yes lol forgot. Here #35 |
|
I will test this code manually tomorrow and we can write tests for dev-server after that. Any idea on how we can test it though? |
|
@saurabhdaware I will add test for the whole deal, don't worry now. This one is on me now |
|
Woah! That will be huge help 🎉 |
pantharshit00
force-pushed
the
feat-add-retries
branch
from
dec1b23
to
3e37ff1
Compare
|
Ok, this is ready for review now. I have added tests for http server and the retry logic. |
| @@ -97,7 +101,7 @@ describe("utils/abell-fs.js - Abell's file system", () => { | |||
| }); | |||
|
|
|||
| after(() => { | |||
| process.chdir('../../../..'); | |||
| process.chdir(__dirname); | |||
There was a problem hiding this comment.
These path changes were very unreliable so I had to refactor them
|
Opened #72 for adding tests for wss |
Yay, first PR to abell. More to come :)
What type of PR is this?
Description
Closes #61
This PR recursively find the next available port if default port is used until 3 levels. It doesn't run this for non-default ports as user has explicitly specified the port there.
Screenshots:
Port 5000 is avaliable
Port 5000 taken
Port 5000, 5001 and 5002 taken
Port 5000, 5001, 5002 and 5003 taken(case which exceed the max retries)
Open questions:
Added unit tests?
(I will add them tomorrow, too sleepy right now)
[optional] Random GIF to +1 someone's day
Here is my dog's picture(name is Arrow :) )
