Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @VariationFlag #20

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Support @VariationFlag #20

merged 2 commits into from
Jun 14, 2023

Conversation

momomomo111
Copy link
Contributor

Previously only @BooleanFlag was supported, but now @VariationFlag is also supported!

@VariationFlagのサポート
テストコードの追加
@momomomo111 momomomo111 self-assigned this Jun 14, 2023
@momomomo111 momomomo111 marked this pull request as ready for review June 14, 2023 09:11
@@ -214,6 +214,60 @@ class DeadlineExpiredDetectorText : LintDetectorTest() {
.expectClean()
}

@Test
fun testVariationFlagFlagTypeWarning() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@momomomo111 momomomo111 merged commit 8953138 into main Jun 14, 2023
@momomomo111 momomomo111 deleted the support-VariationFlag branch June 14, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants