Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error parsing GET request #108

Merged
merged 1 commit into from
May 9, 2023
Merged

fix: error parsing GET request #108

merged 1 commit into from
May 9, 2023

Conversation

abemedia
Copy link
Owner

@abemedia abemedia commented May 9, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Benchmark Result

Benchmark diff with base branch
goos: linux
goarch: amd64
pkg: github.com/abemedia/go-don
cpu: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
          │ bench-master.txt │         bench-new.txt         │
          │      sec/op      │   sec/op     vs base          │
Handler-2        471.2n ± 2%   474.2n ± 2%  ~ (p=0.782 n=10)

          │ bench-master.txt │         bench-new.txt          │
          │       B/op       │    B/op     vs base            │
Handler-2         72.00 ± 0%   72.00 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

          │ bench-master.txt │         bench-new.txt          │
          │    allocs/op     │ allocs/op   vs base            │
Handler-2         2.000 ± 0%   2.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.38 ⚠️

Comparison is base (59ad48e) 93.53% compared to head (d7a940e) 93.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   93.53%   93.16%   -0.38%     
==========================================
  Files          19       19              
  Lines         773      775       +2     
==========================================
- Hits          723      722       -1     
- Misses         35       37       +2     
- Partials       15       16       +1     
Impacted Files Coverage Δ
request.go 92.68% <80.00%> (-7.32%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@abemedia abemedia merged commit 8298a2c into master May 9, 2023
@abemedia abemedia deleted the fix/get-parse-body branch May 9, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant