Don't override default Rest Client delete method.

[ehelms]

This override breaks any other projects use of RestClient that relies
on this gem.

[ehelms]

This is a blocker for the Foreman/Katello project.

[daviddavis]

👍 for this fix

👎 for overriding delete in RestClient.

[pdilung]

Hello All,

@ehelms 👍 Thanks for the fix.

I did this override and indeed your approach is way better than mine. Actually before I have overriden the delete I was thinking about implementing delete with payload but ... 😄

@abenari I think that it would also make sense to roll back to the older version of OVIRT::Client#http_delete and create one variant for delete with payload OVIRT::Client#http_delete_with_payload. Let me your opinion.

[ehelms]

@pdilung It happens :) I thought of a few ways to try and tackle this and this seemed the least invasive while keeping your original intent in tact. Can you estimate a time frame for pushing out a gem with the fix? Mostly to know whether we should pin our Gemfile for a few days or not to right our builds.

[pdilung]

@ehelms I would let @abenari and other stake holders to decide if a rollback to OVIRT::Client#http_delete should take place. I assume the updated gem will be pushed pretty fast. I have already implemented locally a rollback to previous version of OVIRT::Client#http_delete and a payload variant of DELETE method OVIRT::Client#http_delete_with_payload. I can create a pull request tomorrow before noon CET.

[pdilung]

@ehelms Created a pull request #64 that contains a fix that you have introduced in #62 as well as my proposal.