Protect calls to GeoIP calls with our mutex #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracing through the call stack we have: GeoIP_region_by_addr which calls _get_region which calls GeoIP_assign_region_by_inetaddr which calls_GeoIP_seek_record which clobbers our global netmask.
|
Hi Damian, Thank you. It'll be nice when RHEL and the LTS Ubuntu have caught up to the 1.5.x release ... [ eh, I wrote "your" before; I was thinking you worked for MaxMind -- who else would bother to dig around in libgeoip enough to notice this? ] What was the reason for the "embed the mutex" change? Should the mutex be visible/usable by users of the package? What's the use case? Ask |
|
Arggh, I forgot that would make it externally visible. That particular commit can be ditched. |
|
Commit removed and pull request updated -- you should be fine to just merge now. |
abh
added a commit
that referenced
this pull request
Oct 15, 2013
Protect calls to GeoIP calls with our mutex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracing through the call stack we have a few calls that end up calling _GeoIP_seek_record deep in the callstack which clobbers our global netmask. So, even though we don't query for the netmask, to prevent some other goroutine from getting the wrong answer we need to protect these calls too.