Configuration via environment variables #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,7 +40,7 @@ def get_config(config_file_path=None): | |||
| Returns a dictionary with all the possible configuration options, | |||
| with None for the options that were not provided. | |||
| """ | |||
| if not os.path.isfile(config_file_path): | |||
| if os.path.isfile(config_file_path): | |||
There was a problem hiding this comment.
This introduces a bug - it'll raise a ConfigFileNotFoundException in the case where a config file is present. Please revert this change.
There was a problem hiding this comment.
Whoops. I was taking a different approach originally and must have forgotten to revert this part
|
@markunsworth awesome, that looks good to me. Could you make a copy of this and include it as a part of this pull request? Once that's done, I'll get the changes merged and push it out via PyPI. Thanks Mark! |
abh1nav
added a commit
that referenced
this pull request
Jan 4, 2016
Configuration via environment variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to use environment variables before falling back to using a config file