the iconv library is deprecated in ruby 1.9.3 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 this PR. Would love to see this merged for Ruby 2.0 compatibility. |
|
Got tired of waiting and wrote https://github.com/bmuller/burghers - feel free to use! |
|
@bmuller Thanks for this. Given my inactivity on this gem (I don't use it any more), I'd be happy to transfer ownership of this gem to you. Or I can push a change to this gem pointing to yours. |
abhay
added a commit
that referenced
this pull request
Apr 22, 2014
the iconv library is deprecated in ruby 1.9.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it prints a warning every time it comes across this:
iconv is only being used in one place in the calais gem, in Client#enlighten, to convert a string into valid utf-8, ignoring errors. i've migrated this to use ruby 1.9's String#encode, with a fallback to the original code in case the user is running ruby 1.8.
this has silenced the warning and is giving me the same behavior i had before. let me know if you'd like any other changes made to this before inclusion.
regards